<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW - Rename BytecodeGenerator's m_symbolTableStack to m_lexicalScopeStack."
href="https://bugs.webkit.org/show_bug.cgi?id=165768">165768</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>Rename BytecodeGenerator's m_symbolTableStack to m_lexicalScopeStack.
</td>
</tr>
<tr>
<th>Classification</th>
<td>Unclassified
</td>
</tr>
<tr>
<th>Product</th>
<td>WebKit
</td>
</tr>
<tr>
<th>Version</th>
<td>WebKit Local Build
</td>
</tr>
<tr>
<th>Hardware</th>
<td>Unspecified
</td>
</tr>
<tr>
<th>OS</th>
<td>Unspecified
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Severity</th>
<td>Normal
</td>
</tr>
<tr>
<th>Priority</th>
<td>P2
</td>
</tr>
<tr>
<th>Component</th>
<td>JavaScriptCore
</td>
</tr>
<tr>
<th>Assignee</th>
<td>webkit-unassigned@lists.webkit.org
</td>
</tr>
<tr>
<th>Reporter</th>
<td>mark.lam@apple.com
</td>
</tr></table>
<p>
<div>
<pre>The lexical scope in "m_lexicalScopeStack" here refers to a pair of { } in the source code that bounds the scope of variables.
There are 4 places in the code where we call m_symbolTableStack.append() to append a new stack entry. In only 3 of the 4 cases, a symbol table is provided in the new stack entry. In all 4 cases, a scope register is provided in the new stack entry.
Also, 3 of the 4 functions that appends an entry to this stack are named:
1. initializeVarLexicalEnvironment()
2. pushLexicalScopeInternal()
3. emitPushWithScope()
The 4th function is the BytecodeGenerator constructor where it pushes the scope for a module environment.
Based on these details, m_lexicalScopeStack is a better name for this stack than m_symbolTableStack.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>