<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - REGRESSION (r209490): [ios-simulator] LayoutTest fast/shadow-dom/media-shadow-manipulation.html is failing"
href="https://bugs.webkit.org/show_bug.cgi?id=165590#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - REGRESSION (r209490): [ios-simulator] LayoutTest fast/shadow-dom/media-shadow-manipulation.html is failing"
href="https://bugs.webkit.org/show_bug.cgi?id=165590">bug 165590</a>
from <span class="vcard"><a class="email" href="mailto:bfulgham@webkit.org" title="Brent Fulgham <bfulgham@webkit.org>"> <span class="fn">Brent Fulgham</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=165590#c5">comment #5</a>)
<span class="quote">> I fixed the test in <a href="https://trac.webkit.org/changeset/209529">https://trac.webkit.org/changeset/209529</a> for now but we
> should really just remove these tests.
>
> e.g. if we make this test use internals.shadowRoot, then it’s gonna hit the
> assertion in RenderImage.cpp we just added in
> <a href="https://trac.webkit.org/changeset/209431/trunk/Source/WebCore/rendering/">https://trac.webkit.org/changeset/209431/trunk/Source/WebCore/rendering/</a>
> RenderImage.cpp
>
> And this assertion is valid. Nobody should be inserting more than one mode
> as a direct child inside a media element’s shadow tree. So I don’t know how
> we’d make this test work without hitting any assertion.</span >
I'm fine with removing the test now that you've fixed the underlying issue.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>