<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Inspector::InspectorValue class doesn't handle undefined type"
href="https://bugs.webkit.org/show_bug.cgi?id=165506#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Inspector::InspectorValue class doesn't handle undefined type"
href="https://bugs.webkit.org/show_bug.cgi?id=165506">bug 165506</a>
from <span class="vcard"><a class="email" href="mailto:karim@karhm.com" title="Karim <karim@karhm.com>"> <span class="fn">Karim</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=296360&action=diff" name="attach_296360" title="Patch">attachment 296360</a> <a href="attachment.cgi?id=296360&action=edit" title="Patch">[details]</a></span>
Patch
<span class="quote">>Index: Source/JavaScriptCore/ChangeLog
>===================================================================
>--- Source/JavaScriptCore/ChangeLog (revision 209439)
>+++ Source/JavaScriptCore/ChangeLog (working copy)
>@@ -1,3 +1,15 @@
>+2016-12-06 Karim H <<a href="mailto:karim@karhm.com">karim@karhm.com</a>>
>+
>+ Added undefined type and fixed related issues
>+ <a class="bz_bug_link
bz_status_NEW "
title="NEW - Inspector::InspectorValue class doesn't handle undefined type"
href="show_bug.cgi?id=165506">https://bugs.webkit.org/show_bug.cgi?id=165506</a>
>+
>+ Reviewed by NOBODY (OOPS!).
>+
>+ * inspector/InspectorValues.cpp:
>+ (Inspector::InspectorValue::undefined):
>+ * inspector/InspectorValues.h:
>+
> 2016-12-06 Alexey Proskuryakov <<a href="mailto:ap@apple.com">ap@apple.com</a>>
>
> Correct SDKROOT values in xcconfig files
>Index: Source/JavaScriptCore/inspector/InspectorValues.cpp
>===================================================================
>--- Source/JavaScriptCore/inspector/InspectorValues.cpp (revision 209405)
>+++ Source/JavaScriptCore/inspector/InspectorValues.cpp (working copy)
>@@ -485,6 +485,11 @@ Ref<InspectorValue> InspectorValue::null
> return adoptRef(*new InspectorValue);
> }
>
>+Ref<InspectorValue> InspectorValue::undefined()
>+{
>+ return adoptRef(*new InspectorValue(Type::Undefined));
>+}
>+
> Ref<InspectorValue> InspectorValue::create(bool value)
> {
> return adoptRef(*new InspectorValue(value));
>Index: Source/JavaScriptCore/inspector/InspectorValues.h
>===================================================================
>--- Source/JavaScriptCore/inspector/InspectorValues.h (revision 209405)
>+++ Source/JavaScriptCore/inspector/InspectorValues.h (working copy)
>@@ -64,11 +64,13 @@ public:
> break;
> case Type::Object:
> case Type::Array:
>+ case Type::Undefined:
> break;
> }
> }
>
> static Ref<InspectorValue> null();
>+ static Ref<InspectorValue> undefined();
> static Ref<InspectorValue> create(bool);
> static Ref<InspectorValue> create(int);
> static Ref<InspectorValue> create(double);
>@@ -83,10 +85,12 @@ public:
> String,
> Object,
> Array,
>+ Undefined,
> };
>
> Type type() const { return m_type; }
> bool isNull() const { return m_type == Type::Null; }
>+ bool isUndefined() const { return m_type == Type::Undefined; }
>
> bool asBoolean(bool&) const;
> bool asInteger(int&) const;</span ></pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>