<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [iOS] WKWebView should not allow app links to be opened on back or forward navigation"
href="https://bugs.webkit.org/show_bug.cgi?id=165502#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [iOS] WKWebView should not allow app links to be opened on back or forward navigation"
href="https://bugs.webkit.org/show_bug.cgi?id=165502">bug 165502</a>
from <span class="vcard"><a class="email" href="mailto:sam@webkit.org" title="Sam Weinig <sam@webkit.org>"> <span class="fn">Sam Weinig</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=165502#c5">comment #5</a>)
<span class="quote">> (In reply to <a href="show_bug.cgi?id=165502#c4">comment #4</a>)
> > Comment on <span class=""><a href="attachment.cgi?id=296357&action=diff" name="attach_296357" title="Patch (with style fixed) for [iOS] WKWebView should not allow app links to be opened on back or forward navigation">attachment 296357</a> <a href="attachment.cgi?id=296357&action=edit" title="Patch (with style fixed) for [iOS] WKWebView should not allow app links to be opened on back or forward navigation">[details]</a></span>
> > Patch (with style fixed) for [iOS] WKWebView should not allow app links to
> > be opened on back or forward navigation
> >
> > I wonder if a better way to do this would be to update
> > API::NavigationAction::shouldOpenAppLinks() to check that navigationType is
> > not NavigationType::BackForward. I'm actually not sure, Dan?
>
> That’s possible, but that would be encoding (admittedly trivial) policy
> logic into what is currently a data container. I think, however, that
> WebPageProxy::decidePolicyForNavigationAction, which is where we currently
> initialize the NavigationAction, would be a good place to implement this
> policy. I agree that setting the
> m_shouldSuppressAppLinksInNextNavigationPolicyDecision in advance is
> unnecessarily complex and fragile.</span >
One thing I am also not sure of is what history.back()/history.forward()/history.go() should/would here. Probably worth testing.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>