<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW - run-benchmark should have a switch to avoid killing browser process unconditionally"
href="https://bugs.webkit.org/show_bug.cgi?id=165173">165173</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>run-benchmark should have a switch to avoid killing browser process unconditionally
</td>
</tr>
<tr>
<th>Classification</th>
<td>Unclassified
</td>
</tr>
<tr>
<th>Product</th>
<td>WebKit
</td>
</tr>
<tr>
<th>Version</th>
<td>WebKit Nightly Build
</td>
</tr>
<tr>
<th>Hardware</th>
<td>Unspecified
</td>
</tr>
<tr>
<th>OS</th>
<td>Unspecified
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Severity</th>
<td>Normal
</td>
</tr>
<tr>
<th>Priority</th>
<td>P2
</td>
</tr>
<tr>
<th>Component</th>
<td>Tools / Tests
</td>
</tr>
<tr>
<th>Assignee</th>
<td>webkit-unassigned@lists.webkit.org
</td>
</tr>
<tr>
<th>Reporter</th>
<td>clopez@igalia.com
</td>
</tr>
<tr>
<th>CC</th>
<td>dewei_zhu@apple.com, lforschler@apple.com
</td>
</tr>
<tr>
<th>Blocks</th>
<td>164792
</td>
</tr></table>
<p>
<div>
<pre>After r209090 <<a href="http://trac.webkit.org/changeset/209090">http://trac.webkit.org/changeset/209090</a>> run-benchmark in Linux doesn't execute a "killall $browser" when it is asked to run the benchmarks with browser $browser. It instead keeps track of the browser PID it executed and only kill this PID.
This is a desired behaviour when the user is testing on the machine. However for a performance bot running tests automatically it isn't.
After discussing this in <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [Linux] run-benchmark should be able to execute the benchmarks with more browsers"
href="show_bug.cgi?id=164792">bug 164792</a> it seems we can add a command line switch to avoid issuing the killall, so users that want to avoid this behaviour of the script can just activate the switch. And at the same time we can keep as default behaviour killing all process with name $browser.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>