<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_UNCONFIRMED "
title="UNCONFIRMED - [GTK] BadDamage X Window System error in WebKit::AcceleratedBackingStoreX11::update when called from WebPageProxy::exitAcceleratedCompositingMode"
href="https://bugs.webkit.org/show_bug.cgi?id=164303#c13">Comment # 13</a>
on <a class="bz_bug_link
bz_status_UNCONFIRMED "
title="UNCONFIRMED - [GTK] BadDamage X Window System error in WebKit::AcceleratedBackingStoreX11::update when called from WebPageProxy::exitAcceleratedCompositingMode"
href="https://bugs.webkit.org/show_bug.cgi?id=164303">bug 164303</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=164303#c12">comment #12</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=295406&action=diff" name="attach_295406" title="Patch">attachment 295406</a> <a href="attachment.cgi?id=295406&action=edit" title="Patch">[details]</a></span>
> Patch
>
> I'd like Zan to look at this.
>
> Questions:
>
> (a) Isn't this equivalent to trapping the entire function, now? Both calls
> to X11 APIs are within the scope of one trapper or another, we could just
> put the trapper at the top so we only need one instead of two.</span >
Not exactly the same, first one only happens if we already have a surface and second one if there's a pixmap and drawing area. We could just move it, though, but I prefer to make more expliit what we are protecting.
<span class="quote">> (b) It occurs to me that it's probably a bad idea to trap errors
> unconditionally here. We really want to ignore errors only if shutting down,
> right? Is there any way we can do that, or are we just out of luck and have
> to trap always?</span >
Not really, there are a lot of situation in which this can happen, for example if the web process crashes in the middle of update, the pixmap is gone but we have a pixmap id in the Ui process. Also because of the async way X11 works, sometimes errors happen later, on a sync, so we could be failing due to previous errors. If you take a look at other projects using X11 directly like GTK+, cairo or clutter you will see they are full of xerror trappers.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>