<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [SOUP] Simplify custom protocols handler implementation"
href="https://bugs.webkit.org/show_bug.cgi?id=164922#c14">Comment # 14</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [SOUP] Simplify custom protocols handler implementation"
href="https://bugs.webkit.org/show_bug.cgi?id=164922">bug 164922</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=295159&action=diff" name="attach_295159" title="Patch">attachment 295159</a> <a href="attachment.cgi?id=295159&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=295159&action=review">https://bugs.webkit.org/attachment.cgi?id=295159&action=review</a>
<span class="quote">>> Source/WebKit2/UIProcess/API/efl/ewk_url_scheme_request_private.h:59
>> + WebKit::CustomProtocolManagerProxy* manager() const { return m_wkRequestManager; }
>
> The return value here should be a const pointer. If you need to return a non-const pointer, then you should add an overload that is not a const member function.</span >
This is EFL code I can't test, so I prefer to not change anything in this part, unless EFL guys confirm the change is ok.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>