<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:achristensen@apple.com" title="Alex Christensen <achristensen@apple.com>"> <span class="fn">Alex Christensen</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Add URL::hostAndPort()"
href="https://bugs.webkit.org/show_bug.cgi?id=164907">bug 164907</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #295141 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Add URL::hostAndPort()"
href="https://bugs.webkit.org/show_bug.cgi?id=164907#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Add URL::hostAndPort()"
href="https://bugs.webkit.org/show_bug.cgi?id=164907">bug 164907</a>
from <span class="vcard"><a class="email" href="mailto:achristensen@apple.com" title="Alex Christensen <achristensen@apple.com>"> <span class="fn">Alex Christensen</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=295141&action=diff" name="attach_295141" title="Patch">attachment 295141</a> <a href="attachment.cgi?id=295141&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=295141&action=review">https://bugs.webkit.org/attachment.cgi?id=295141&action=review</a>
<span class="quote">> Source/WebCore/html/URLUtils.h:132
> if (!url.port() || isDefaultPortForProtocol(url.port().value(), url.protocol()))
> return url.host();</span >
We can also remove this. The new URLParser will always remove the port if it's the default port for the protocol.
Same with the check for hostEnd and pathStart.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>