<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Fix build on macOS Sierra when WEB_PLAYBACK_CONTROLS_MANAGER is enabled"
href="https://bugs.webkit.org/show_bug.cgi?id=164845#c9">Comment # 9</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Fix build on macOS Sierra when WEB_PLAYBACK_CONTROLS_MANAGER is enabled"
href="https://bugs.webkit.org/show_bug.cgi?id=164845">bug 164845</a>
from <span class="vcard"><a class="email" href="mailto:mitz@webkit.org" title="mitz@webkit.org <mitz@webkit.org>"> <span class="fn">mitz@webkit.org</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=164845#c8">comment #8</a>)
<span class="quote">> (In reply to <a href="show_bug.cgi?id=164845#c7">comment #7</a>)
> > (In reply to <a href="show_bug.cgi?id=164845#c6">comment #6</a>)
> > > (In reply to <a href="show_bug.cgi?id=164845#c5">comment #5</a>)
> > > > (In reply to <a href="show_bug.cgi?id=164845#c3">comment #3</a>)
> > > > > (In reply to <a href="show_bug.cgi?id=164845#c2">comment #2</a>)
> > > > > > Why is this the right fix?
> > > > >
> > > > > This is similar to the fix we deployed in AVKit.h but I'm all ears if you
> > > > > have a better fix.
> > > >
> > > > I don’t know what you’re referring to (AVKit.h is not in the WebKit source
> > > > tree, is it?). When the Apple Internal SDK isn’t available, we normally use
> > > > declarations in a *SPI.h header file rather than omit functionality from the
> > > > build.
> > >
> > > Sorry, I meant to say AVKitSPI.h
> >
> > What’s guarded with #if USE(APPLE_INTERNAL_SDK) in AVKitSPI.h are just
> > #import statements for headers that are only available in the Apple-internal
> > SDK, and the #else clause provides equivalent declarations. What attachment
> > 295001 [details] guards with #if USE(APPLE_INTERNAL_SDK) are parts of the
> > implementation, and the #else clauses don’t seem to be equivalent.
>
> Oh I see. So you think the correct fix is to declare the missing properties
> in AVKitSPI.h instead?</span >
I don’t know what the original build error was, but if there’s anything that’s declared in one of the Apple-internal headers that AVKitSPI.h imports, and that declaration is missing from the #else clause, and adding it would fix the build, then in principle that’s the right fix :-)</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>