<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:mitz@webkit.org" title="mitz@webkit.org <mitz@webkit.org>"> <span class="fn">mitz@webkit.org</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Implement WebPlaybackControlsManager"
href="https://bugs.webkit.org/show_bug.cgi?id=164789">bug 164789</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #294876 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Implement WebPlaybackControlsManager"
href="https://bugs.webkit.org/show_bug.cgi?id=164789#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Implement WebPlaybackControlsManager"
href="https://bugs.webkit.org/show_bug.cgi?id=164789">bug 164789</a>
from <span class="vcard"><a class="email" href="mailto:mitz@webkit.org" title="mitz@webkit.org <mitz@webkit.org>"> <span class="fn">mitz@webkit.org</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=294876&action=diff" name="attach_294876" title="Patch">attachment 294876</a> <a href="attachment.cgi?id=294876&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=294876&action=review">https://bugs.webkit.org/attachment.cgi?id=294876&action=review</a>
<span class="quote">> Source/WebCore/platform/mac/WebPlaybackControlsManager.h:29
> +#import "AVKitSPI.h"</span >
Since this is a framework header, it should import other WebCore headers using <WebCore/ syntax.
<span class="quote">> Source/WebCore/platform/mac/WebPlaybackControlsManager.h:42
> +@interface WebPlaybackControlsManager : NSObject<AVFunctionBarPlaybackControlsControlling> {</span >
Missing space before the <.
<span class="quote">> Source/WebCore/platform/mac/WebPlaybackControlsManager.h:65
> +@property NSTimeInterval seekToTime;</span >
This could probably be nonatomic (as could may other properties here).
<span class="quote">> Source/WebCore/platform/mac/WebPlaybackControlsManager.h:68
> +@property BOOL hasEnabledAudio;
> +@property BOOL hasEnabledVideo;</span >
Can be nonatomic.
<span class="quote">> Source/WebCore/platform/mac/WebPlaybackControlsManager.h:70
> +@property (nonatomic, retain, readwrite) NSArray<AVFunctionBarMediaSelectionOption *> *audioFunctionBarMediaSelectionOptions;
> +@property (nonatomic, retain, readwrite) NSArray<AVFunctionBarMediaSelectionOption *> *legibleFunctionBarMediaSelectionOptions;</span >
We normally omit “readwrite” when possible. It’s a little unusual for a property whose value is NSArray to be “retain” rather than “copy”.
<span class="quote">> Source/WebCore/platform/mac/WebPlaybackControlsManager.mm:98
> + completionHandler(@[], nil);</span >
Missing space between the brackets.
<span class="quote">> Source/WebCore/platform/mac/WebPlaybackControlsManager.mm:104
> + completionHandler(@[], nil);</span >
Ditto.
<span class="quote">> Source/WebCore/platform/mac/WebPlaybackControlsManager.mm:132
> + _audioFunctionBarMediaSelectionOptions = audioOptions;</span >
I’d make a copy of audioOptions here (and change the property from “retain” to “copy”.
<span class="quote">> Source/WebCore/platform/mac/WebPlaybackControlsManager.mm:149
> + if (audioMediaSelectionOption && self.audioFunctionBarMediaSelectionOptions)</span >
We normally don’t use trivial accessors from within a class’s own implementation, but just use the ivar directly.
<span class="quote">> Source/WebCore/platform/mac/WebPlaybackControlsManager.mm:162
> + _legibleFunctionBarMediaSelectionOptions = legibleOptions;</span >
I’d make a copy of legibleOptions here (and change the property from “retain” to “copy”.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>