<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Support for HTML Media Capture API"
href="https://bugs.webkit.org/show_bug.cgi?id=43239#c14">Comment # 14</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Support for HTML Media Capture API"
href="https://bugs.webkit.org/show_bug.cgi?id=43239">bug 43239</a>
from <span class="vcard"><a class="email" href="mailto:thorton@apple.com" title="Tim Horton <thorton@apple.com>"> <span class="fn">Tim Horton</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=294532&action=diff" name="attach_294532" title="Proposed patch v3">attachment 294532</a> <a href="attachment.cgi?id=294532&action=edit" title="Proposed patch v3">[details]</a></span>
Proposed patch v3
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=294532&action=review">https://bugs.webkit.org/attachment.cgi?id=294532&action=review</a>
<span class="quote">> Source/WebKit2/UIProcess/Cocoa/WKUserMediaProviderCocoa.mm:67
> + void (^uiDelegateAuthorizationBlock)(void) = ^ {</span >
Much of this should be in UIDelegate
<span class="quote">> Source/WebKit2/UIProcess/Cocoa/WKUserMediaProviderCocoa.mm:73
> + if ((requiresAudio!= authorizedMicrophone) || (requiresVideo != authorizedCamera)) {</span >
space before the !=
<span class="quote">> Source/WebKit2/UIProcess/WKUserMediaProvider.h:40
> +class WKUserMediaProvider {</span >
Now that this is a C++ class in the WebKit namespace you can (should!) drop the prefix.
<span class="quote">> Source/WebKit2/UIProcess/WKUserMediaProvider.h:45
> + virtual void mediaStateDidChange(WebCore::MediaProducer::MediaStateFlags, WKWebView*) = 0;</span >
Very surprised to see WKWebView here.
<span class="quote">> Source/WebKit2/UIProcess/ios/PageClientImplIOS.mm:231
> +WKUserMediaProvider& PageClientImpl::userMediaProvider()</span >
This all seems wrong. It should be owned by WebPageProxy, know nothing about WKWebView, and communicate with WKWebView and friends when needed via the PageClient/UIClient/etc.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>