<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - Shadow DOM: Toggling class in `.class ::slotted(*)` does not trigger style recalc"
href="https://bugs.webkit.org/show_bug.cgi?id=160864#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - Shadow DOM: Toggling class in `.class ::slotted(*)` does not trigger style recalc"
href="https://bugs.webkit.org/show_bug.cgi?id=160864">bug 160864</a>
from <span class="vcard"><a class="email" href="mailto:rniwa@webkit.org" title="Ryosuke Niwa <rniwa@webkit.org>"> <span class="fn">Ryosuke Niwa</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=294518&action=diff" name="attach_294518" title="patch">attachment 294518</a> <a href="attachment.cgi?id=294518&action=edit" title="patch">[details]</a></span>
patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=294518&action=review">https://bugs.webkit.org/attachment.cgi?id=294518&action=review</a>
<span class="quote">> Source/WebCore/css/StyleInvalidationAnalysis.cpp:114
> + m_didInvalidateHostChildren = true;</span >
It seems like we don't need to set m_didInvalidateHostChildren if the slot isn't in a shadow tree?
Or is this a kind of optimization to avoid checking whether element is in the shadow tree or not?
<span class="quote">> Source/WebCore/css/StyleInvalidationAnalysis.cpp:132
> + if (shouldCheckForSlots)
> + return CheckDescendants::Yes;</span >
Don't we need to check the descendants of a 2nd, 3rd, etc... slot elements?
i.e. don't we need to check just !m_ruleSet.slottedPseudoElementRules().isEmpty()?
Put it another way, does this work if a single shadow root had multiple slots
each of which had to be invalidated?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>