<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Support TouchBar in WebKit"
href="https://bugs.webkit.org/show_bug.cgi?id=164437#c27">Comment # 27</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Support TouchBar in WebKit"
href="https://bugs.webkit.org/show_bug.cgi?id=164437">bug 164437</a>
from <span class="vcard"><a class="email" href="mailto:bdakin@apple.com" title="Beth Dakin <bdakin@apple.com>"> <span class="fn">Beth Dakin</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=164437#c26">comment #26</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=294046&action=diff" name="attach_294046" title="Patch">attachment 294046</a> <a href="attachment.cgi?id=294046&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=294046&action=review">https://bugs.webkit.org/attachment.cgi?id=294046&action=review</a>
>
> > Source/WebKit/mac/WebView/WebView.mm:9577
> > +- (void)webViewAdditionsWillDestroyView
>
> Could we rename this to -webViewWillDestroyView? (It looks like the
> "Additions" terminology is being dropped from other places).
> Alternately, maybe we don't need a separate function on the WebView for
> performing cleanup in -[WebView dealloc] -- I think it makes sense just to
> move the cleanup logic directly to -dealloc and remove the
> -webViewWillDestroyView helper.
>
> This also applies to the WebKit2 case (webViewImplAdditionsWillDestroyView)</span >
Good find. I removed the functions entirely.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>