<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Refactor MathIC compilation process in Baseline and DFG to turn temporary registers usage more flexible"
href="https://bugs.webkit.org/show_bug.cgi?id=160588#c32">Comment # 32</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Refactor MathIC compilation process in Baseline and DFG to turn temporary registers usage more flexible"
href="https://bugs.webkit.org/show_bug.cgi?id=160588">bug 160588</a>
from <span class="vcard"><a class="email" href="mailto:sbarati@apple.com" title="Saam Barati <sbarati@apple.com>"> <span class="fn">Saam Barati</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=294030&action=diff" name="attach_294030" title="Patch">attachment 294030</a> <a href="attachment.cgi?id=294030&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=294030&action=review">https://bugs.webkit.org/attachment.cgi?id=294030&action=review</a>
<span class="quote">> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:3563
> + GPRReg scratchGPR[Generator::scratchGPRRegCount];
> + FPRReg scratchFPR[Generator::scratchFPRRegCount];</span >
I'm more of a fan of using Vector<> with an inline capacity for this API. You'll still get the same property where you don't end up mallocing any memory.
<span class="quote">> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:3600
> + for (size_t i = 0; i < std::min<unsigned>(availableGPRs, scratchGPRRegCount); i++) {</span >
It seems wrong if the min() expression ever returns availableGPRs instead of scratchGPRRegCount. I would just turn this into an assert that we have enough registers.
<span class="quote">> Source/JavaScriptCore/jit/JITMulGenerator.h:45
> + FPRReg leftFPR, FPRReg rightFPR, GPRReg *scratchGPRs, FPRReg *scratchFPRs)</span >
See my comment about using Vector here instead. You could even templatize it over Vector type to not have to worry about what the inline capacity of it is.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>