<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Support TouchBar in WebKit"
href="https://bugs.webkit.org/show_bug.cgi?id=164437#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Support TouchBar in WebKit"
href="https://bugs.webkit.org/show_bug.cgi?id=164437">bug 164437</a>
from <span class="vcard"><a class="email" href="mailto:bdakin@apple.com" title="Beth Dakin <bdakin@apple.com>"> <span class="fn">Beth Dakin</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=164437#c3">comment #3</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=293959&action=diff" name="attach_293959" title="Patch">attachment 293959</a> <a href="attachment.cgi?id=293959&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=293959&action=review">https://bugs.webkit.org/attachment.cgi?id=293959&action=review</a>
>
> > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:176
> > +#if HAVE(TOUCH_BAR)
>
> I think this would look less ugly as its own class extension (you can have
> as many as you want!) but either way is fine.
> </span >
Good point. Fixed!
<span class="quote">> > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:4573
> > + return NO;
>
> If HAVE(TOUCH_BAR) is true, you return twice?
> </span >
Yeah, the compiler didn't complain, but I fixed it.
<span class="quote">> > Source/WebKit2/UIProcess/API/mac/WKView.mm:1505
> > + return NO;
>
> And here.
> </span >
Fixed.
<span class="quote">> > Source/WebKit2/UIProcess/Cocoa/WebViewImpl.mm:971
> > + NSTextAlignment textAlignment;
> > + switch (editorState.postLayoutData().textAlignment) {
> > + case NoAlignment:
> > + textAlignment = NSTextAlignmentNatural;
> > + break;
>
> Should factor this out. Maybe we already have one?
> </span >
I don't believe it exists anywhere already. This will be a good follow-up.
<span class="quote">> > Source/WebKit2/UIProcess/Cocoa/WebViewImpl.mm:1111
> > + CFNotificationCenterRemoveObserver(CFNotificationCenterGetLocalCenter(), this, (__bridge CFStringRef)NSTouchBarDidExitCustomization, 0);
>
> __bridge? In non-ARC code?
> </span >
Good point. It's been bothering me that this uses CFNotificationCenter instead of NSNotificationCenter, so I have changed it to use NSNotificationCenter.
<span class="quote">> > Source/WebKit/mac/WebView/WebView.mm:5136
> > +#if HAVE(TOUCH_BAR)
>
> Why not around the whole thing?
> </span >
Fixed.
<span class="quote">> > Source/WebKit/mac/WebView/WebView.mm:6865
> > + NSRange resultRange = [nsResult range];
>
> Dots.
> </span >
Fixed.
<span class="quote">> > Source/WebKit/mac/WebView/WebView.mm:6868
> > + result.replacement = [nsResult replacementString];
>
> Dots.
> </span >
Fixed.
<span class="quote">> > Source/WebKit/mac/WebView/WebView.mm:9465
> > + NSTextAlignment textAlignment;
> > + switch (style->textAlign()) {
> > + case RIGHT:
> > + case WEBKIT_RIGHT:
> > + textAlignment = NSTextAlignmentRight;
>
> And again.</span >
Will do in follow-up.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>