<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - MemoryPressureHandler shouldn't know how to release WebCore memory"
href="https://bugs.webkit.org/show_bug.cgi?id=160497">bug 160497</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #291638 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - MemoryPressureHandler shouldn't know how to release WebCore memory"
href="https://bugs.webkit.org/show_bug.cgi?id=160497#c25">Comment # 25</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - MemoryPressureHandler shouldn't know how to release WebCore memory"
href="https://bugs.webkit.org/show_bug.cgi?id=160497">bug 160497</a>
from <span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=291638&action=diff" name="attach_291638" title="Fix the build">attachment 291638</a> <a href="attachment.cgi?id=291638&action=edit" title="Fix the build">[details]</a></span>
Fix the build
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=291638&action=review">https://bugs.webkit.org/attachment.cgi?id=291638&action=review</a>
Andreas liked the initial version of the patch (see <a href="show_bug.cgi?id=160497#c2">comment #2</a>), and I think not much has changed; I think we can count that as owner approval if there are not any objections. It looks like a good fix for these layering violations. A couple questions:
<span class="quote">> Source/WebCore/platform/MemoryPressureHandler.cpp:62
> + if (!m_lowMemoryHandler)
> + return;</span >
Wouldn't an early return here be a bug? Shouldn't there be an assertion here?
<span class="quote">> Source/WebCore/platform/MemoryPressureHandler.h:173
> + void (^m_releaseMemoryBlock)() { nullptr };</span >
I know this was here before, but... what is this???</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>