<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - Plugin process crashes in NPN_InvokeDefault"
href="https://bugs.webkit.org/show_bug.cgi?id=137425#c12">Comment # 12</a>
on <a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - Plugin process crashes in NPN_InvokeDefault"
href="https://bugs.webkit.org/show_bug.cgi?id=137425">bug 137425</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=137425#c11">comment #11</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=293142&action=diff" name="attach_293142" title="Patch">attachment 293142</a> <a href="attachment.cgi?id=293142&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=293142&action=review">https://bugs.webkit.org/attachment.cgi?id=293142&action=review</a>
>
> Thanks very much for working on this, it will cut my downstream bug queue by
> about a quarter.</span >
Note that this is not enough, the bug in in the plugin.
<span class="quote">> Unfortunately it broke macOS tests, which will need to be investigated:</span >
There's nothing to investigate, as I said the test needs to be added to xcode, I knew it was not going to work.
<span class="quote">> Regressions: Unexpected text-only failures (1)
> plugins/browser-funcs-invalid-args.html [ Failure ]
>
> Regressions: Unexpected timeouts (1)
> plugins/npruntime/npruntime-calls-with-null-npp.html [ Timeout ]
>
> > Source/WebKit2/ChangeLog:9
> > + the same approach than Firefox.
>
> than -> as</span >
English is hard.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>