<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Add support for wide gamut for ShareableBitmap for image popovers"
href="https://bugs.webkit.org/show_bug.cgi?id=164001#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Add support for wide gamut for ShareableBitmap for image popovers"
href="https://bugs.webkit.org/show_bug.cgi?id=164001">bug 164001</a>
from <span class="vcard"><a class="email" href="mailto:thorton@apple.com" title="Tim Horton <thorton@apple.com>"> <span class="fn">Tim Horton</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=292860&action=diff" name="attach_292860" title="Patch">attachment 292860</a> <a href="attachment.cgi?id=292860&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=292860&action=review">https://bugs.webkit.org/attachment.cgi?id=292860&action=review</a>
<span class="quote">> Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp:101
> +// // Out-of-date CG installations will not honor kCGColorSpaceSRGB. This logic avoids</span >
I think it is likely that if not all Windowses know about kCGColorSpaceSRGB, they won't know about kCGColorSpaceExtendedSRGB either, so probably just un-comment this out.
<span class="quote">> Source/WebCore/platform/graphics/cg/GraphicsContextCG.h:37
> +WEBCORE_EXPORT CGColorSpaceRef extendedsRGBColorSpaceRef();</span >
I do not love the lowercase s. What do others think?
<span class="quote">> Source/WebKit2/Platform/IPC/Decoder.cpp:249
> +bool Decoder::decode(size_t& result)</span >
This is a bad idea, the two sides of IPC can be different bittiness - this has bitten us before. Just use uint64_t everywhere.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>