<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [EFL] REGRESSION(r207616): Build is broken due to missing libgeoclue-dev package"
href="https://bugs.webkit.org/show_bug.cgi?id=163733#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [EFL] REGRESSION(r207616): Build is broken due to missing libgeoclue-dev package"
href="https://bugs.webkit.org/show_bug.cgi?id=163733">bug 163733</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=163733#c0">comment #0</a>)
<span class="quote">> I tried an EFL WebKit build on a fresh new Ubuntu 16.04
> machine and got the following build error:
>
> In file included from
> ../../Source/WebCore/platform/geoclue/GeolocationProviderGeoclue1.cpp:27:0:
> ../../Source/WebCore/platform/geoclue/GeolocationProviderGeoclue.h:32:36:
> fatal error: geoclue/geoclue-master.h: No such file or directory
> compilation terminated.
>
> It seems <a href="https://trac.webkit.org/changeset/204445">https://trac.webkit.org/changeset/204445</a> is the culprit.
>
> geoclue/geoclue-master.h is in libgeoclue-dev package,
> but after r204445, only libgeoclue-2-dev is installed.
>
> But the question is what is the proper fix?
> - adding geoclue-2.0 to <efl|gtk>/install-dependencies
> --> isn't enough, because USE(GEOCLUE2) isn't exposed to the build
> - Source/cmake/OptionsEfl.cmake should use SET_AND_EXPOSE_TO_BUILD similar
> to GTK
> - fixing the geoclue 1 build
> - removing the geoclue path
> - whatever else
>
> Additionally I got the following warnings which should be fixed or
> suppressed:
> DerivedSources/WebCore/Geoclue2Interface.c: In function
> 'geoclue_manager_complete_get_client':
> DerivedSources/WebCore/Geoclue2Interface.c:673:21: warning: unused parameter
> 'object' [-Wunused-parameter]
> DerivedSources/WebCore/Geoclue2Interface.c: In function
> 'geoclue_manager_complete_add_agent':
> DerivedSources/WebCore/Geoclue2Interface.c:693:21: warning: unused parameter
> 'object' [-Wunused-parameter]
> DerivedSources/WebCore/Geoclue2Interface.c: In function
> 'geoclue_client_complete_start':
> DerivedSources/WebCore/Geoclue2Interface.c:2373:20: warning: unused
> parameter 'object' [-Wunused-parameter]
> DerivedSources/WebCore/Geoclue2Interface.c: In function
> 'geoclue_client_complete_stop':
> DerivedSources/WebCore/Geoclue2Interface.c:2391:20: warning: unused
> parameter 'object' [-Wunused-parameter]</span >
This is generated code, Michael suppressed those warnings in GTK+ build in r206381 with:
set_source_files_properties(${DERIVED_SOURCES_WEBCORE_DIR}/Geoclue2Interface.c PROPERTIES COMPILE_FLAGS -Wno-unused-parameter)
<span class="quote">>
> note: I just reported this bug, but have no time and interest
> in fixing it myself. I'm going to upload my WIP patch, feel
> free to pick it up if it is important for somebody.</span ></pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>