<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:clopez@igalia.com" title="Carlos Alberto Lopez Perez <clopez@igalia.com>"> <span class="fn">Carlos Alberto Lopez Perez</span></a>
</span> changed
<a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [GTK] REGRESSION(r207396 and r207521) Build broken with Clang 3.6"
href="https://bugs.webkit.org/show_bug.cgi?id=163599">bug 163599</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Summary</td>
<td>[GTK] REGRESSION(r207396) Build broken with Clang.
</td>
<td>[GTK] REGRESSION(r207396 and r207521) Build broken with Clang 3.6
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [GTK] REGRESSION(r207396 and r207521) Build broken with Clang 3.6"
href="https://bugs.webkit.org/show_bug.cgi?id=163599#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [GTK] REGRESSION(r207396 and r207521) Build broken with Clang 3.6"
href="https://bugs.webkit.org/show_bug.cgi?id=163599">bug 163599</a>
from <span class="vcard"><a class="email" href="mailto:clopez@igalia.com" title="Carlos Alberto Lopez Perez <clopez@igalia.com>"> <span class="fn">Carlos Alberto Lopez Perez</span></a>
</span></b>
<pre>More info about this issue:
It turns out that after fixing this, r207521 caused again a build failure related to the issue.
It seem this is caused because Clang 3.6 doesn't implement <a href="http://www.open-std.org/jtc1/sc22/wg21/docs/cwg_defects.html#1591">http://www.open-std.org/jtc1/sc22/wg21/docs/cwg_defects.html#1591</a>
See: <a href="https://llvm.org/bugs/show_bug.cgi?id=23904">https://llvm.org/bugs/show_bug.cgi?id=23904</a> and <a href="https://llvm.org/bugs/show_bug.cgi?id=24694">https://llvm.org/bugs/show_bug.cgi?id=24694</a>
The code could be patched as follows to make it build:
--- a/Source/WebCore/testing/Internals.cpp
+++ b/Source/WebCore/testing/Internals.cpp
@@ -1156,7 +1156,7 @@ ExceptionOr<String> Internals::configurationForViewport(float devicePixelRatio,
restrictMinimumScaleFactorToViewportSize(attributes, IntSize(availableWidth, availableHeight), devicePixelRatio);
restrictScaleFactorToInitialScaleIfNotUserScalable(attributes);
- return String { "viewport size " + String::number(attributes.layoutSize.width()) + "x" + String::number(attributes.layoutSize.height()) + " scale " + String::number(attributes.initialScale) + " with limits [" + String::number(attributes.minimumScale) + ", " + String::number(attributes.maximumScale) + "] and userScalable " + (attributes.userScalable ? "true" : "false") };
+ return String("viewport size " + String::number(attributes.layoutSize.width()) + "x" + String::number(attributes.layoutSize.height()) + " scale " + String::number(attributes.initialScale) + " with limits [" + String::number(attributes.minimumScale) + ", " + String::number(attributes.maximumScale) + "] and userScalable " + (attributes.userScalable ? "true" : "false"));
}
ExceptionOr<bool> Internals::wasLastChangeUserEdit(Element& textField)
@@ -1218,7 +1218,7 @@ ExceptionOr<String> Internals::autofillFieldName(Element& element)
if (!is<HTMLFormControlElement>(element))
return Exception { INVALID_NODE_TYPE_ERR };
- return String { downcast<HTMLFormControlElement>(element).autofillData().fieldName };
+ return String { downcast<HTMLFormControlElement>(element).autofillData().fieldName.string() };
}
ExceptionOr<void> Internals::paintControlTints()
But reached this point, I don't think is worth.
On the GTK port we only need to support GCC, and this build just fine with GCC 4.9 which is the minimum version of GCC that we support.
Using clang is a personal choice, and I have just upgraded to Clang 3.8 that build this just fine.
I advice to anyone also having problems to upgrade the version of Clang.
Just a heads up.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>