<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:achristensen@apple.com" title="Alex Christensen <achristensen@apple.com>"> <span class="fn">Alex Christensen</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [SOUP] Add NetworkSession implementation and switch to use it"
href="https://bugs.webkit.org/show_bug.cgi?id=163597">bug 163597</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #292081 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [SOUP] Add NetworkSession implementation and switch to use it"
href="https://bugs.webkit.org/show_bug.cgi?id=163597#c16">Comment # 16</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [SOUP] Add NetworkSession implementation and switch to use it"
href="https://bugs.webkit.org/show_bug.cgi?id=163597">bug 163597</a>
from <span class="vcard"><a class="email" href="mailto:achristensen@apple.com" title="Alex Christensen <achristensen@apple.com>"> <span class="fn">Alex Christensen</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=292081&action=diff" name="attach_292081" title="Try to fix the builds">attachment 292081</a> <a href="attachment.cgi?id=292081&action=edit" title="Try to fix the builds">[details]</a></span>
Try to fix the builds
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=292081&action=review">https://bugs.webkit.org/attachment.cgi?id=292081&action=review</a>
r=me
<span class="quote">> Source/WebKit2/NetworkProcess/Downloads/Download.h:50
> +#if USE(NETWORK_SESSION)</span >
Let's just put this into the #if USE(NETWORK_SESSION) right above it.
<span class="quote">> Source/WebKit2/NetworkProcess/Downloads/Download.h:55
> +class NetworkDataTask;</span >
Let's put this below. Forward declaring an unused class doesn't cause problems.
<span class="quote">> Source/WebKit2/NetworkProcess/Downloads/Download.h:59
> +#else
> +typedef void* PlatformDownloadTaskRef;</span >
Let's not start defining things for a hypothetical third implementation. If someone wants to make another implementation, they can define what they want.
<span class="quote">> Source/WebKit2/NetworkProcess/Downloads/Download.h:148
> #else
> + PlatformDownloadTaskRef m_download;</span >
Let's remove this. It will need to be some kind of smart pointer anyways.
<span class="quote">> Source/WebKit2/NetworkProcess/NetworkLoad.cpp:274
> + if (m_task && m_task->isDownload())</span >
isPendingDownload
<span class="quote">> Source/WebKit2/NetworkProcess/soup/NetworkDataTaskSoup.cpp:52
> + , m_session(&session)</span >
It looks like we could make m_session a Ref.
<span class="quote">> Source/WebKit2/NetworkProcess/soup/NetworkDataTaskSoup.cpp:144
> + url.setQuery(String());
> + url.removeFragmentIdentifier();</span >
I think these are unnecessary
<span class="quote">> Source/WebKit2/NetworkProcess/soup/NetworkSessionSoup.cpp:37
> +Ref<NetworkSession> NetworkSession::create(Type type, SessionID sessionID, CustomProtocolManager*)</span >
Maybe in a followup patch, and definitely an existing problem from my implementation, but it seems like type and sessionID contain redundant information. Type could be removed.
<span class="quote">> Source/WebKit2/config.h:78
> -#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101200) || (PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 100000)
> +#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101200) || (PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 100000) || USE(SOUP)</span >
I haven't tested this on linux. If you want, you could land this as a separate change so if it needs to be reverted then it's easier to revert a one line change than all this code.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>