<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: [Mac] roleDescription for AXTextField input types"
href="https://bugs.webkit.org/show_bug.cgi?id=163419">bug 163419</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #291556 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: [Mac] roleDescription for AXTextField input types"
href="https://bugs.webkit.org/show_bug.cgi?id=163419#c10">Comment # 10</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: [Mac] roleDescription for AXTextField input types"
href="https://bugs.webkit.org/show_bug.cgi?id=163419">bug 163419</a>
from <span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=291556&action=diff" name="attach_291556" title="patch">attachment 291556</a> <a href="attachment.cgi?id=291556&action=edit" title="patch">[details]</a></span>
patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=291556&action=review">https://bugs.webkit.org/attachment.cgi?id=291556&action=review</a>
<span class="quote">> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:2520
> + Node* node = m_object->node();</span >
Slightly better to use auto:
auto* node = m_object->node();
<span class="quote">> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:2521
> + if (node && is<HTMLInputElement>(*node)) {</span >
The is<> function handles null checks if you pass it a pointer:
if (is<HTMLInputElement>(node)) {
<span class="quote">> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:2522
> + HTMLInputElement& input = downcast<HTMLInputElement>(*node);</span >
Best style is to not repeat the type:
auto& input = downcast<HTMLInputElement>(*node);
<span class="quote">> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:2531
> + const AtomicString& type = m_object->getAttribute(typeAttr);</span >
Should write:
auto& type = input.attributeWithoutSynchronization(typeAttr);
Instead of going back to the accessibility object, now that we know this is an input element.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>