<html>
    <head>
      <base href="https://bugs.webkit.org/" />
    </head>
    <body><table border="1" cellspacing="0" cellpadding="8">
        <tr>
          <th>Bug ID</th>
          <td><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - REGRESSION(r206189): logs error statements when URLRequest is canceled"
   href="https://bugs.webkit.org/show_bug.cgi?id=163393">163393</a>
          </td>
        </tr>

        <tr>
          <th>Summary</th>
          <td>REGRESSION(r206189): logs error statements when URLRequest is canceled
          </td>
        </tr>

        <tr>
          <th>Classification</th>
          <td>Unclassified
          </td>
        </tr>

        <tr>
          <th>Product</th>
          <td>WebKit
          </td>
        </tr>

        <tr>
          <th>Version</th>
          <td>Other
          </td>
        </tr>

        <tr>
          <th>Hardware</th>
          <td>PC
          </td>
        </tr>

        <tr>
          <th>OS</th>
          <td>Linux
          </td>
        </tr>

        <tr>
          <th>Status</th>
          <td>NEW
          </td>
        </tr>

        <tr>
          <th>Severity</th>
          <td>Normal
          </td>
        </tr>

        <tr>
          <th>Priority</th>
          <td>P2
          </td>
        </tr>

        <tr>
          <th>Component</th>
          <td>WebKit2
          </td>
        </tr>

        <tr>
          <th>Assignee</th>
          <td>webkit-unassigned&#64;lists.webkit.org
          </td>
        </tr>

        <tr>
          <th>Reporter</th>
          <td>mcatanzaro&#64;igalia.com
          </td>
        </tr>

        <tr>
          <th>CC</th>
          <td>bugs-noreply&#64;webkitgtk.org, krollin&#64;apple.com
          </td>
        </tr></table>
      <p>
        <div>
        <pre>r206189 &quot;Add new logging for network resource loading&quot; added a new error in WebLoaderStrategy::loadResource:

RELEASE_LOG_ERROR_IF_ALLOWED(frame, &quot;loadResource: Unable to create SubresourceLoader (frame = %p&quot;, &amp;frame);

However, this error statement is hit during normal operation when there is no error, whenever a load is canceled by changing the URL of an API::URLRequest to NULL during a willSendRequestForFrame callback (see InjectedBundlePageResourceLoadClient::willSendRequestForFrame). For example, the error statement is printed once each time Epiphany's adblocker blocks an ad.

Either (a) WebLoaderStrategy::loadResource should never be called when the load has already been canceled, or (b) WebLoaderStrategy::loadResource should not print an error in this case. Not sure which way is correct, but I don't plan to investigate (a) so here is a patch to do (b).</pre>
        </div>
      </p>
      <hr>
      <span>You are receiving this mail because:</span>
      
      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>