<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Extend event stream to include interpolated events and add a force press test that uses that interpolation"
href="https://bugs.webkit.org/show_bug.cgi?id=163161#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Extend event stream to include interpolated events and add a force press test that uses that interpolation"
href="https://bugs.webkit.org/show_bug.cgi?id=163161">bug 163161</a>
from <span class="vcard"><a class="email" href="mailto:wenson_hsieh@apple.com" title="Wenson Hsieh <wenson_hsieh@apple.com>"> <span class="fn">Wenson Hsieh</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=291001&action=diff" name="attach_291001" title="Patch">attachment 291001</a> <a href="attachment.cgi?id=291001&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=291001&action=review">https://bugs.webkit.org/attachment.cgi?id=291001&action=review</a>
<span class="quote">> Tools/WebKitTestRunner/ios/HIDEventGenerator.mm:131
> +static pressureInterpolationFunction interplations[] = {</span >
interplations[] => interpolations[]?
<span class="quote">> Tools/WebKitTestRunner/ios/HIDEventGenerator.mm:233
> + if ([string isEqualToString:HIDEventInterpolationTypeLinear])</span >
Can we remove this [string isEqualToString:HIDEventInterpolationTypeLinear] check here?
<span class="quote">> Tools/WebKitTestRunner/ios/HIDEventGenerator.mm:975
> + InterpolationType interpType = interpolationFromString(interpolationsDictionary[HIDEventInterpolateKey]);</span >
Nit - I think we generally don't abbreviate variable names per style guidelines (i.e. it should be interpolationType here).
<span class="quote">> Tools/WebKitTestRunner/ios/HIDEventGenerator.mm:982
> + NSTimeInterval time = startTime;</span >
Should this be starting at startTime + timeStep, or just startTime? From the while loop, it seems like we'll stop before computing the touch dictionary corresponding to endTime, so it seems a bit strange we're including startTime's touch dictionary in here.
<span class="quote">> Tools/WebKitTestRunner/ios/HIDEventGenerator.mm:989
> + double t = (time - startTime) / (endTime - startTime);</span >
Nit - we can pull (endTime - startTime) out of the while loop. Could we also name this variable something like 'progress'?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>