<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:achristensen@apple.com" title="Alex Christensen <achristensen@apple.com>"> <span class="fn">Alex Christensen</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Network Session: PendingDownload is always nullptr in DownloadManager::dataTaskBecameDownloadTask"
href="https://bugs.webkit.org/show_bug.cgi?id=163006">bug 163006</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #290936 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Network Session: PendingDownload is always nullptr in DownloadManager::dataTaskBecameDownloadTask"
href="https://bugs.webkit.org/show_bug.cgi?id=163006#c10">Comment # 10</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Network Session: PendingDownload is always nullptr in DownloadManager::dataTaskBecameDownloadTask"
href="https://bugs.webkit.org/show_bug.cgi?id=163006">bug 163006</a>
from <span class="vcard"><a class="email" href="mailto:achristensen@apple.com" title="Alex Christensen <achristensen@apple.com>"> <span class="fn">Alex Christensen</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=290936&action=diff" name="attach_290936" title="Fix coding style">attachment 290936</a> <a href="attachment.cgi?id=290936&action=edit" title="Fix coding style">[details]</a></span>
Fix coding style
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=290936&action=review">https://bugs.webkit.org/attachment.cgi?id=290936&action=review</a>
This should have no change in behavior. There are already some download tests, and I just verified that this doesn't cause a problem on Mac.
<span class="quote">> Source/WebKit2/ChangeLog:25
> + return eearly if both are nullptr to avoid crashes. However, we are checking that the download is in the</span >
early</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>