<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Ensure NetworkProcess is ready before whitelisting TLS certificates"
href="https://bugs.webkit.org/show_bug.cgi?id=162962">bug 162962</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #290698 Flags</td>
<td>commit-queue?
</td>
<td>commit-queue-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Ensure NetworkProcess is ready before whitelisting TLS certificates"
href="https://bugs.webkit.org/show_bug.cgi?id=162962#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Ensure NetworkProcess is ready before whitelisting TLS certificates"
href="https://bugs.webkit.org/show_bug.cgi?id=162962">bug 162962</a>
from <span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=290698&action=diff" name="attach_290698" title="Patch">attachment 290698</a> <a href="attachment.cgi?id=290698&action=edit" title="Patch">[details]</a></span>
Patch
Indeed, the ASSERT is not helpful here.
This looks easy to test, so if you don't want to risk it breaking in the next refactoring, it would be nice if you could try to add a test for it in TestSSL.cpp. The only trick is that you can't use the nice SSLTest class since that doesn't give you the ability to use the WebKitWebContext before the WebKitWebView is created; you'd have to roll your own that inherits from Test rather than LoadTrackingTest/WebViewTest.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>