<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Unite op_get_by_id_with_this with op_get_by_id"
href="https://bugs.webkit.org/show_bug.cgi?id=162124#c20">Comment # 20</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Unite op_get_by_id_with_this with op_get_by_id"
href="https://bugs.webkit.org/show_bug.cgi?id=162124">bug 162124</a>
from <span class="vcard"><a class="email" href="mailto:ticaiolima@gmail.com" title="Caio Lima <ticaiolima@gmail.com>"> <span class="fn">Caio Lima</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=162124#c19">comment #19</a>)
<span class="quote">> Why would we do this?</span >
If I didn't miss any context *_with_this were created to solve the bug on (<a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Getter and setter on super are called with wrong "this" object"
href="show_bug.cgi?id=147064">https://bugs.webkit.org/show_bug.cgi?id=147064</a>). The current implementationis just a call to slow paths "operation*WithThis", meaning that we don't use IC or PIC on "super.foo" for example.
Merging get_by_id_with_this with op_get_by_id we enable its optimization including IC and PIC. In terms of performance, now it means 20% faster over op_get_by_id_with_this version.
<span class="quote">> It's definitely good for lower tiers that get_by_id does not take an extra
> this operand. It's also easier to parse. I don't understand why we would
> remove this optimization.</span >
I didn't understand why it is easier to parse.
Also, About good parts of get_by_id does not take an extra this operand, do you mind explain me why? I can think that we use extra memory to store the this operand, which has a big impact because get_by_id is one of the most used op_codes.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>