<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Offline asm should not output masm assembly when using a x86_64 asm backend"
href="https://bugs.webkit.org/show_bug.cgi?id=162705#c17">Comment # 17</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Offline asm should not output masm assembly when using a x86_64 asm backend"
href="https://bugs.webkit.org/show_bug.cgi?id=162705">bug 162705</a>
from <span class="vcard"><a class="email" href="mailto:Christopher.reid@sony.com" title="Christopher Reid <Christopher.reid@sony.com>"> <span class="fn">Christopher Reid</span></a>
</span></b>
<pre>Created <span class=""><a href="attachment.cgi?id=290282" name="attach_290282" title="Work in progress patch">attachment 290282</a> <a href="attachment.cgi?id=290282&action=edit" title="Work in progress patch">[details]</a></span>
Work in progress patch
Here's a WIP patch for supporting isMSVC to use isWIN on the asm.rb side. I moved the comment style to be specific to which backend code is being generated for.
<span class="quote">> + $output.puts("//" + inputHash)</span >
The one problem I had was it's a chicken and an egg problem for which comment style to use for the initial hash comment. Currently, we need to use either ';' or '//' to store the hashes to check to see if we need to re-build. We don't know what backends we're building for until we start parsing the file and we need to put the hash comment before we start generating outputs for each backend. There will also be problems if there's a mix of backends using different comment styles.
Here's some possible solutions for this problem:
- Buffer the output and write afer we've generated code for all backends and customize the comment then
- Switch to a new way to check for changes rather than storing hashes in comments
- Output the comment based on the first backend we use
Do you have any other ideas or input on how I should go about this?
Thanks</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>