<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:simon.fraser@apple.com" title="Simon Fraser (smfr) <simon.fraser@apple.com>"> <span class="fn">Simon Fraser (smfr)</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Test for long press on image"
href="https://bugs.webkit.org/show_bug.cgi?id=162657">bug 162657</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #290050 Flags</td>
<td>review?
</td>
<td>review-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Test for long press on image"
href="https://bugs.webkit.org/show_bug.cgi?id=162657#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Test for long press on image"
href="https://bugs.webkit.org/show_bug.cgi?id=162657">bug 162657</a>
from <span class="vcard"><a class="email" href="mailto:simon.fraser@apple.com" title="Simon Fraser (smfr) <simon.fraser@apple.com>"> <span class="fn">Simon Fraser (smfr)</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=290050&action=diff" name="attach_290050" title="Patch">attachment 290050</a> <a href="attachment.cgi?id=290050&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=290050&action=review">https://bugs.webkit.org/attachment.cgi?id=290050&action=review</a>
r- for the build breakage, but looks good. The actual new test is missing, though.
<span class="quote">> Source/WebKit2/ChangeLog:10
> + Wrote a test for long press on an image, and used the sheet scraping functionality
> + to make sure that the correct actions were being displayed.</span >
You might want to reference the revision that added the code you're now testing.
<span class="quote">> Source/WebKit2/ChangeLog:12
> + Reviewed by NOBODY (OOPS!).</span >
This line should go above the description
<span class="quote">> Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:266
> +- (NSDictionary *)contentsOfUserInterfaceItem:(NSString *)userInterfaceItem WK_API_AVAILABLE(ios(WK_IOS_TBA));</span >
This should have a leading underscore, as we do for all private properties and functions (as should the ones above, which I'll fix later).
<span class="quote">> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.h:234
> - (void)selectFormAccessoryPickerRow:(NSInteger)rowIndex;
> +- (NSDictionary *)contentsOfUserInterfaceItem:(NSString *)userInterfaceItem;</span >
We should use underscores here as well; put one on contentsOfUserInterfaceItem.
<span class="quote">> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:3855
> + return @{userInterfaceItem:[_actionSheetAssistant currentAvailableActionStrings]};</span >
Preferred spacing is:
return @{ userInterfaceItem: [_actionSheetAssistant currentAvailableActionStrings] };
<span class="quote">> Tools/TestRunnerShared/UIScriptContext/UIScriptController.h:77
> + JSObjectRef contentsOfUserInterfaceItem(JSStringRef item) const;</span >
No need for the "item" parameter name.
<span class="quote">> Tools/TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:65
> + // Returned object has a list of string the describe actions</span >
Comment isn't quite accurate: its'a dictionary with a key matching interfaceItem which might have arbitrary content inside.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>