<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Offline asm should not output masm assembly when using a x86_64 asm backend"
href="https://bugs.webkit.org/show_bug.cgi?id=162705#c14">Comment # 14</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Offline asm should not output masm assembly when using a x86_64 asm backend"
href="https://bugs.webkit.org/show_bug.cgi?id=162705">bug 162705</a>
from <span class="vcard"><a class="email" href="mailto:mark.lam@apple.com" title="Mark Lam <mark.lam@apple.com>"> <span class="fn">Mark Lam</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=162705#c13">comment #13</a>)
<span class="quote">> (In reply to <a href="show_bug.cgi?id=162705#c12">comment #12</a>)
>
> Thanks for your feedback Mark,
>
> > It looks like this change is the only one that is of consequence. All the
> > other changes below only change the code to use a local var (initialized by
> > a function) instead of a global var. Are they really necessary? Or did I
> > misread something?
>
> What was happening there was that the activebackend was not being set until
> later on in the code when some node operations are done in backends.rb. In
> ruby, class and instance level variables are resolved when the file is
> included which was causing the generate offsets script to fail too.</span >
OK. Sounds good.
<span class="quote">> > 2. change isMSVC to be based on isWin.
> The same problem as above is seen here, isWin is called from asm.rb before
> the backend is set. For wincairo and other platforms that use cmake, the
> correct file name is set in cmake which causes emitWinAsm to be set
> correctly. DWARF2 annotations will still be incorrectly set for cross
> compiling to a x86_(_64)_win backend. It would be a nice change to have but
> it is much more involved.
>
> I agree with removing isGCC, I can make a patch for that. Let me know if you
> think it's still worthwhile to remove isMSVC.</span >
You can just remove isGCC in this patch. Add a comment in the ChangeLog to say that it is unused.
You should not remove isMSVC. I think you should update it to use isWin like you did for isIntelSyntax.
You should remove isCompiledForWindows since it will be now unused after the above changes.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>