<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_UNCONFIRMED "
title="UNCONFIRMED - [WK2] Keyboard menu key should show context menu"
href="https://bugs.webkit.org/show_bug.cgi?id=72099#c28">Comment # 28</a>
on <a class="bz_bug_link
bz_status_UNCONFIRMED "
title="UNCONFIRMED - [WK2] Keyboard menu key should show context menu"
href="https://bugs.webkit.org/show_bug.cgi?id=72099">bug 72099</a>
from <span class="vcard"><a class="email" href="mailto:tpopela@redhat.com" title="Tomas Popela <tpopela@redhat.com>"> <span class="fn">Tomas Popela</span></a>
</span></b>
<pre>I decided to move the issue of no context menu when no element to focused to another bug, to not block this one.
(In reply to <a href="show_bug.cgi?id=72099#c27">comment #27</a>)
<span class="quote">> So, if it's covered by existing tests, what tests pass after this change?
> Can we unskip any test, or are those currently failing with no
> expectations?. I think it would be great for the GTK+ port if we add a test
> case for this to our current context menu unit tests.</span >
I will test the popup-menu handling in TestContextMenu. Also there are manual tests that are testing this issue:
ManualTests/keyboard-menukey-event.html
ManualTests/win/contextmenu-key.html
ManualTests/win/contextmenu-key2.html
<span class="quote">> I also wonder if we should prevent
> sending this key event to the web process, since it's going to be handled by
> context menu key event, or returning TRUE from webkitWebViewBasePopupMenu
> already prevents this?</span >
Actually the key-press-event is emitted before the popup-menu one so we don't need to handle this at all.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>