<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Switch to use GMenu internally in the context menu implementation"
href="https://bugs.webkit.org/show_bug.cgi?id=162603#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Switch to use GMenu internally in the context menu implementation"
href="https://bugs.webkit.org/show_bug.cgi?id=162603">bug 162603</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=162603#c2">comment #2</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=289933&action=diff" name="attach_289933" title="Patch">attachment 289933</a> <a href="attachment.cgi?id=289933&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=289933&action=review">https://bugs.webkit.org/attachment.cgi?id=289933&action=review</a>
>
> Thank you!
>
> > Source/WebKit2/ChangeLog:8
> > + Switch to use GAction instead of GtkAtion internally, but still keeping a GtkAction associated to the GAction,
>
> GtkAtion -> GtkAction
>
> > Source/WebKit2/Shared/gtk/WebContextMenuItemGtk.cpp:160
> > + GUniquePtr<char> actionName(g_strdup_printf("action-%" G_GUINT64_FORMAT, ++actionID));
>
> Nit: since it's a uint64_t rather than a guint64, I would print it with
> PRIu64
>
> > Source/WebKit2/UIProcess/gtk/WebContextMenuProxyGtk.h:64
> > + HashMap<unsigned long, void*> m_signalHandlers;
>
> I don't understand, why use void* instead of GAction*? GAction* would
> obviously be safer.</span >
To avoid casts between GAction - GSimpleAction. I don't think there any risk in using void*, g_signal_handler_disconnect expects a gpointer, and this is used privately only.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>