<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GStreamer] Support a direct GPU-to-GPU copy of video textures to WebGL"
href="https://bugs.webkit.org/show_bug.cgi?id=159928#c16">Comment # 16</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GStreamer] Support a direct GPU-to-GPU copy of video textures to WebGL"
href="https://bugs.webkit.org/show_bug.cgi?id=159928">bug 159928</a>
from <span class="vcard"><a class="email" href="mailto:magomez@igalia.com" title="Miguel Gomez <magomez@igalia.com>"> <span class="fn">Miguel Gomez</span></a>
</span></b>
<pre>Awesome, I was just about to ping a reviewer to give it a look and you were faster Carlos.
Also a reply to one of your comments:
<span class="quote">> > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:773
> > + GLContext* glContext = PlatformDisplay::sharedDisplayForCompositing().sharingGLContext();
> > + cairo_device_t* device = glContext->cairoDevice();
> > +
> > + // Thread-awareness is a huge performance hit on non-Intel drivers.
> > + cairo_gl_device_set_thread_aware(device, FALSE);
> > +
> > + IntSize size = IntSize(GST_VIDEO_INFO_WIDTH(&videoInfo), GST_VIDEO_INFO_HEIGHT(&videoInfo));
> > + IntSize rotatedSize = m_videoSourceOrientation.usesWidthAsHeight() ? size.transposedSize() : size;
> > +
>
> Don't you need to make the context current in this case?
> </span >
Making the context current in that case is not needed. Setting thread awareness is just a flag, doesn't need the context to be current, and also the context->bindTexture() call three lines below will make current the weblg context again.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>