<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] webkit-gtk-2.14.0 build failure of ScrollbarThemeGtk with libc++"
href="https://bugs.webkit.org/show_bug.cgi?id=162302">bug 162302</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #289387 Flags</td>
<td>review+
</td>
<td>review-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] webkit-gtk-2.14.0 build failure of ScrollbarThemeGtk with libc++"
href="https://bugs.webkit.org/show_bug.cgi?id=162302#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] webkit-gtk-2.14.0 build failure of ScrollbarThemeGtk with libc++"
href="https://bugs.webkit.org/show_bug.cgi?id=162302">bug 162302</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=289387&action=diff" name="attach_289387" title="0002-GTK-Fix-build-failure-of-ScrollbarThemeGtk-with-libc">attachment 289387</a> <a href="attachment.cgi?id=289387&action=edit" title="0002-GTK-Fix-build-failure-of-ScrollbarThemeGtk-with-libc">[details]</a></span>
0002-GTK-Fix-build-failure-of-ScrollbarThemeGtk-with-libc
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=289387&action=review">https://bugs.webkit.org/attachment.cgi?id=289387&action=review</a>
<span class="quote">> Source/WebCore/platform/gtk/ScrollbarThemeGtk.cpp:547
> - contentsRect.move(std::abs(rect.width() - preferredSize.width()), 0);
> + contentsRect.move(std::abs((double)(rect.width() - preferredSize.width())), 0);</span >
I think it would be cleaner to cast the result of abs, because both rect and preferredSize are ints, instead of using the abs overload for floats with integers, we could use the int one and cast the result. Another way to disambiguate this could be using std::fabs, adn then we don't need any ugly cast.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>