<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - REGRESSION(r194387): Crash on github.com in IntlDateTimeFormat::resolvedOptions in C locale"
href="https://bugs.webkit.org/show_bug.cgi?id=162139">bug 162139</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #289442 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - REGRESSION(r194387): Crash on github.com in IntlDateTimeFormat::resolvedOptions in C locale"
href="https://bugs.webkit.org/show_bug.cgi?id=162139#c8">Comment # 8</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - REGRESSION(r194387): Crash on github.com in IntlDateTimeFormat::resolvedOptions in C locale"
href="https://bugs.webkit.org/show_bug.cgi?id=162139">bug 162139</a>
from <span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=289442&action=diff" name="attach_289442" title="Patch">attachment 289442</a> <a href="attachment.cgi?id=289442&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=289442&action=review">https://bugs.webkit.org/attachment.cgi?id=289442&action=review</a>
<span class="quote">> LayoutTests/js/intl-invalid-locale-crash.html:10
> +if (window.internals) {
> + window.internals.setUserPreferredLanguages(["a"]);</span >
Please add a comment to indicate that you're doing this to ensure the script gets run with an invalid locale.
<span class="quote">> Source/JavaScriptCore/runtime/IntlCollator.cpp:261
> + throwTypeError(&state, scope, ASCIILiteral("failed to initialize Collator"));</span >
Wouldn't it be good to indicate why? "failed to initialize Collator due to invalid locale"?
<span class="quote">> Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp:976
> + for (size_t i = 0; languageList[i]; ++i) {
> + // Dot not propagate the C locale to WebCore.</span >
"Do not"
And since you changed the line above anyway, I would change size_t to auto as well.
<span class="quote">> Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp:-979
> - WebCore::languageDidChange();</span >
What, why dropping this? This looks like an accident. Please don't commit without responding to this.
<span class="quote">> Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:491
> + // When using the C locale, en-US should be used as default.</span >
I would copy/paste this entire block to add a test for POSIX locale as well.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>