<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:simon.fraser@apple.com" title="Simon Fraser (smfr) <simon.fraser@apple.com>"> <span class="fn">Simon Fraser (smfr)</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - REGRESSION (?): background-position animation is broken in transitions/background-position-transitions.html"
href="https://bugs.webkit.org/show_bug.cgi?id=161843">bug 161843</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>simon.fraser@apple.com
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - REGRESSION (?): background-position animation is broken in transitions/background-position-transitions.html"
href="https://bugs.webkit.org/show_bug.cgi?id=161843#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - REGRESSION (?): background-position animation is broken in transitions/background-position-transitions.html"
href="https://bugs.webkit.org/show_bug.cgi?id=161843">bug 161843</a>
from <span class="vcard"><a class="email" href="mailto:simon.fraser@apple.com" title="Simon Fraser (smfr) <simon.fraser@apple.com>"> <span class="fn">Simon Fraser (smfr)</span></a>
</span></b>
<pre>Parking this here:
diff --git a/LayoutTests/transitions/resources/transition-test-helpers.js b/LayoutTests/transitions/resources/transition-test-helpers.js
index 069986e60a08e37eb06e87ed96b1f22fa1d14cb0..b8a14b97db0f71051c82ce0f9d9918c22a5296be 100644
--- a/LayoutTests/transitions/resources/transition-test-helpers.js
+++ b/LayoutTests/transitions/resources/transition-test-helpers.js
@@ -110,6 +110,52 @@ function parseClipPath(s)
return null;
}
+function hasFloatValue(valueType)
+{
+ switch (valueType) {
+ case CSSPrimitiveValue.CSS_FR:
+ case CSSPrimitiveValue.CSS_NUMBER:
+ case CSSPrimitiveValue.CSS_PARSER_INTEGER:
+ case CSSPrimitiveValue.CSS_PERCENTAGE:
+ case CSSPrimitiveValue.CSS_EMS:
+ case CSSPrimitiveValue.CSS_EXS:
+ case CSSPrimitiveValue.CSS_CHS:
+ case CSSPrimitiveValue.CSS_REMS:
+ case CSSPrimitiveValue.CSS_PX:
+ case CSSPrimitiveValue.CSS_CM:
+ case CSSPrimitiveValue.CSS_MM:
+ case CSSPrimitiveValue.CSS_IN:
+ case CSSPrimitiveValue.CSS_PT:
+ case CSSPrimitiveValue.CSS_PC:
+ case CSSPrimitiveValue.CSS_DEG:
+ case CSSPrimitiveValue.CSS_RAD:
+ case CSSPrimitiveValue.CSS_GRAD:
+ case CSSPrimitiveValue.CSS_TURN:
+ case CSSPrimitiveValue.CSS_MS:
+ case CSSPrimitiveValue.CSS_S:
+ case CSSPrimitiveValue.CSS_HZ:
+ case CSSPrimitiveValue.CSS_KHZ:
+ case CSSPrimitiveValue.CSS_DIMENSION:
+ case CSSPrimitiveValue.CSS_VW:
+ case CSSPrimitiveValue.CSS_VH:
+ case CSSPrimitiveValue.CSS_VMIN:
+ case CSSPrimitiveValue.CSS_VMAX:
+ case CSSPrimitiveValue.CSS_DPPX:
+ case CSSPrimitiveValue.CSS_DPI:
+ case CSSPrimitiveValue.CSS_DPCM:
+ return true;
+ }
+ return false;
+}
+
+function getNumericValue(cssValue)
+{
+ if (hasFloatValue(cssValue.primitiveType))
+ return cssValue.getFloatValue(cssValue.primitiveType);
+
+ return -1;
+}
+
function checkExpectedValue(expected, index)
{
var time = expected[index][0];
@@ -196,7 +242,8 @@ function checkExpectedValue(expected, index)
for (var i = 0; i < computedStyle.length; ++i) {
switch (computedStyle[i].cssValueType) {
case CSSValue.CSS_PRIMITIVE_VALUE:
- values.push(computedStyle[i].getFloatValue(CSSPrimitiveValue.CSS_NUMBER));
+ if (hasFloatValue(computedStyle[i]))
+ values.push(computedStyle[i].getFloatValue(CSSPrimitiveValue.CSS_NUMBER));
break;
case CSSValue.CSS_CUSTOM:
// arbitrarily pick shadow-x and shadow-y</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>