<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK][Threaded Compositor] Several flaky tests"
href="https://bugs.webkit.org/show_bug.cgi?id=161242#c16">Comment # 16</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK][Threaded Compositor] Several flaky tests"
href="https://bugs.webkit.org/show_bug.cgi?id=161242">bug 161242</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=161242#c15">comment #15</a>)
<span class="quote">> (In reply to <a href="show_bug.cgi?id=161242#c14">comment #14</a>)
> > Finally found the issue. The problem is the viewport controller, that is
> > changed by the fixed layout tests, but never reset. There's also a problem
> > with the fixed layout tests that could leave the view in an inconsistent
> > state as I explained in <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [Coordinated Graphics] Test fast/fixed-layout/fixed-layout.html crashes in debug"
href="show_bug.cgi?id=160117">bug #160117</a>. I'm already working on a proper fix,
> > but in the meantime I've skipped fixed layout tests (they are only two) to
> > make sure we don't see all those flaky tests in the bots anymore. To easily
> > reproduce it, launch run-webkit-tests with a single worker job and run fixed
> > layout test first and then other ref tests, for example:
> >
> > $ run-webkit-tests --gtk --release --child-processes=1
> > fast/fixed-layout/fixed-layout.html fast/regions
>
> It's clearly a big improvement, good job.
>
> But it's still not completely fixed. We have 50 unexpected passes in build
> #18009, for example. These are tests that normally always fail, but
> occasionally pass now that we've enabled threaded compositor.</span >
You are assuming again that there's a single issue. This particular problem that was making both the expected and actual rendering of reftest fail, was caused by the fixed layout (it changes the viewport controller state that is never reset). Of course there are more issues, but I think the situation now is mostly the same to what we had before switching to the threaded compositor.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>