<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:joepeck@webkit.org" title="Joseph Pecoraro <joepeck@webkit.org>"> <span class="fn">Joseph Pecoraro</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Web Inspector: Add resource timing model with timing information"
href="https://bugs.webkit.org/show_bug.cgi?id=161314">bug 161314</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #287280 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Web Inspector: Add resource timing model with timing information"
href="https://bugs.webkit.org/show_bug.cgi?id=161314#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Web Inspector: Add resource timing model with timing information"
href="https://bugs.webkit.org/show_bug.cgi?id=161314">bug 161314</a>
from <span class="vcard"><a class="email" href="mailto:joepeck@webkit.org" title="Joseph Pecoraro <joepeck@webkit.org>"> <span class="fn">Joseph Pecoraro</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=287280&action=diff" name="attach_287280" title="Patch">attachment 287280</a> <a href="attachment.cgi?id=287280&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=287280&action=review">https://bugs.webkit.org/attachment.cgi?id=287280&action=review</a>
r=me, though please double check with earlier iOS devices to make sure things still work there.
<span class="quote">> Source/WebInspectorUI/ChangeLog:31
> + Update timing object with info on from response.</span >
Typo: "on from response"
<span class="quote">> Source/WebInspectorUI/UserInterface/Main.html:355
> + <script src="Models/ResourceTimingData.js"></script></span >
Style: Alphabetical order. Even though "Resource" uses "ResourceTimingData" the order is fine because neither are actually used until after all scripts have loaded.
<span class="quote">> Source/WebInspectorUI/UserInterface/Models/Resource.js:475
> this._responseHeadersSize = String(this._statusCode).length + this._statusText.length + 12; // Extra length is for "HTTP/1.1 ", " ", and "\r\n".</span >
Gosh, just noticed this wouldn't work for HTTP/2. Nothing you need to change.
<span class="quote">> Source/WebInspectorUI/UserInterface/Models/Resource.js:579
> + this._timingData._responseEnd = elapsedTime || NaN;</span >
Setting a private member like this is sketchy. Normally we would create some public method on ResourceTimingData and call here it. Something like:
markResponseEndTime(responseEnd)
<span class="quote">> Source/WebInspectorUI/UserInterface/Models/ResourceTimelineRecord.js:55
> - return this._resource.requestSentTimestamp;
> + return this._resource.timingData.startTime;</span >
Same thing here.
<span class="quote">> Source/WebInspectorUI/UserInterface/Models/ResourceTimingData.js:68
> + // Static</span >
Style: Static methods, like this, normally go above the Public block.
<span class="quote">> LayoutTests/http/tests/inspector/network/resource-timing.html:11
> +function resolve(url) {
> + let a = document.createElement('a');
> + a.href = url;
> + return a.href;
> +}</span >
This function doesn't appear to be used. Drop it?
<span class="quote">> LayoutTests/http/tests/inspector/network/resource-timing.html:13
> +function createRequest()
> +{</span >
Nit: My style in tests would be to put this brace on the same line as the function name because it is outside of the test() function. But I may be the only one that uses this style.
<span class="quote">> LayoutTests/http/tests/inspector/network/resource-timing.html:21
> + let suite = InspectorTest.createAsyncSuite("ResourceTiming");</span >
Lets name this after the model object "ResourceTimingData".</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>