<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - charactersAroundPosition can be wrong because it crosses editing boundaries"
href="https://bugs.webkit.org/show_bug.cgi?id=161215#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - charactersAroundPosition can be wrong because it crosses editing boundaries"
href="https://bugs.webkit.org/show_bug.cgi?id=161215">bug 161215</a>
from <span class="vcard"><a class="email" href="mailto:bdakin@apple.com" title="Beth Dakin <bdakin@apple.com>"> <span class="fn">Beth Dakin</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=161215#c4">comment #4</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=287027&action=diff" name="attach_287027" title="Patch">attachment 287027</a> <a href="attachment.cgi?id=287027&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=287027&action=review">https://bugs.webkit.org/attachment.cgi?id=287027&action=review</a>
>
> It looks like fast/dom/focus-contenteditable.html is failing on WebKit2.
> Please check that before landing it.
> </span >
I investigated, and this test is going back to its pre-<a href="https://trac.webkit.org/changeset/195078">https://trac.webkit.org/changeset/195078</a> state. That change caused this test to have a different layout because it caused more layouts to happen. Now that we don’t allow the call to charactersAroundPosition() to cross editing boundaries, those layouts don’t happen, and we have the old behavior back.
<span class="quote">> > Source/WebCore/ChangeLog:5
> > + -and corresponding-
>
> I don't think we need this line.
>
> > Source/WebCore/ChangeLog:14
> > + VisiblePosition::previous().
> > + * editing/VisibleUnits.cpp:
>
> We need a blank line here.
> </span >
Added.
<span class="quote">> > LayoutTests/editing/mac/spelling/accept-candidate-without-crossing-editing-boundary.html:3
> > +<script src=../../editing.js language="javascript" type="text/javascript"></script>
>
> We don't need language & type attributes.
> </span >
Removed.
<span class="quote">> > LayoutTests/editing/mac/spelling/accept-candidate-without-crossing-editing-boundary.html:10
> > + var s = window.getSelection();
>
> It looks like this variable is never used.
> </span >
Removed.
<span class="quote">> > LayoutTests/editing/mac/spelling/accept-candidate-without-crossing-editing-boundary.html:32
> > +<div style="visibility:hidden;">
> > + <br>
> > +</div>
> > +
> > +<div style="width: 1px; height: 1px;"></div>
>
> Do we really need these stray elements?</span >
We do!! These elements are key to reproduce the bug. When charactersAroundPosition can cross editing boundaries, this DOM structure tricks it into thinking that the <br> inside the hidden div is the character before the caret. And when we think a newline is the character before the caret, we don't replace the typed text with the candidate.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>