<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:rniwa@webkit.org" title="Ryosuke Niwa <rniwa@webkit.org>"> <span class="fn">Ryosuke Niwa</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - charactersAroundPosition can be wrong because it crosses editing boundaries"
href="https://bugs.webkit.org/show_bug.cgi?id=161215">bug 161215</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #287027 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - charactersAroundPosition can be wrong because it crosses editing boundaries"
href="https://bugs.webkit.org/show_bug.cgi?id=161215#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - charactersAroundPosition can be wrong because it crosses editing boundaries"
href="https://bugs.webkit.org/show_bug.cgi?id=161215">bug 161215</a>
from <span class="vcard"><a class="email" href="mailto:rniwa@webkit.org" title="Ryosuke Niwa <rniwa@webkit.org>"> <span class="fn">Ryosuke Niwa</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=287027&action=diff" name="attach_287027" title="Patch">attachment 287027</a> <a href="attachment.cgi?id=287027&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=287027&action=review">https://bugs.webkit.org/attachment.cgi?id=287027&action=review</a>
It looks like fast/dom/focus-contenteditable.html is failing on WebKit2. Please check that before landing it.
<span class="quote">> Source/WebCore/ChangeLog:5
> + -and corresponding-</span >
I don't think we need this line.
<span class="quote">> Source/WebCore/ChangeLog:14
> + VisiblePosition::previous().
> + * editing/VisibleUnits.cpp:</span >
We need a blank line here.
<span class="quote">> LayoutTests/editing/mac/spelling/accept-candidate-without-crossing-editing-boundary.html:3
> +<script src=../../editing.js language="javascript" type="text/javascript"></script></span >
We don't need language & type attributes.
<span class="quote">> LayoutTests/editing/mac/spelling/accept-candidate-without-crossing-editing-boundary.html:10
> + var s = window.getSelection();</span >
It looks like this variable is never used.
<span class="quote">> LayoutTests/editing/mac/spelling/accept-candidate-without-crossing-editing-boundary.html:32
> +<div style="visibility:hidden;">
> + <br>
> +</div>
> +
> +<div style="width: 1px; height: 1px;"></div></span >
Do we really need these stray elements?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>