<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:fred.wang@free.fr" title="Frédéric Wang (:fredw) <fred.wang@free.fr>"> <span class="fn">Frédéric Wang (:fredw)</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Use LayoutUnit values for MathML ascent"
href="https://bugs.webkit.org/show_bug.cgi?id=155879">bug 155879</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>distler@golem.ph.utexas.edu
</td>
</tr>
<tr>
<td style="text-align:right;">Depends on</td>
<td>85730
</td>
<td>161136, 161127
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Use LayoutUnit values for MathML ascent"
href="https://bugs.webkit.org/show_bug.cgi?id=155879#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Use LayoutUnit values for MathML ascent"
href="https://bugs.webkit.org/show_bug.cgi?id=155879">bug 155879</a>
from <span class="vcard"><a class="email" href="mailto:fred.wang@free.fr" title="Frédéric Wang (:fredw) <fred.wang@free.fr>"> <span class="fn">Frédéric Wang (:fredw)</span></a>
</span></b>
<pre>I'm not exactly sure why firstLineBaseline() must return an (Optional) int for MathML (besides the fact that MathML renderer classes used to derive from flexboxes). I think we want to use LayoutUnit as much as possible.
I'm making this depends on <a class="bz_bug_link
bz_status_NEW "
title="NEW - More cleanup for the mpadded implementation"
href="show_bug.cgi?id=161136">bug 161136</a> and <a class="bz_bug_link
bz_status_NEW "
title="NEW - RenderMathMLRow::firstLineBaseline does not need to be overridden in RenderMathMLMenclose"
href="show_bug.cgi?id=161127">bug 161127</a> which allow to implement firstLineBaseline() without having to store LayoutUnit members and keep them updated. In general, it seems that performing a simple computation is always better than having to use a (possible not up-to-date class member).
I'm cc'int Jacques Distler as he reported an issue with the alignment of <span class=""><a href="attachment.cgi?id=286836" name="attach_286836" title="Testcase">attachment 286836</a> <a href="attachment.cgi?id=286836&action=edit" title="Testcase">[details]</a></span> that I suspect is due to this bug (but I was not able to reproduce it).</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>