<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Sample Process on notifyDone timed out"
href="https://bugs.webkit.org/show_bug.cgi?id=161063#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Sample Process on notifyDone timed out"
href="https://bugs.webkit.org/show_bug.cgi?id=161063">bug 161063</a>
from <span class="vcard"><a class="email" href="mailto:jbedard@apple.com" title="Jonathan Bedard <jbedard@apple.com>"> <span class="fn">Jonathan Bedard</span></a>
</span></b>
<pre>A few notes about this patch: There are a number of techniques used in this patch that do not seem to adhere to the architecture of WebKit. This particular code path is classified as a timeout, but the location and logging of this type of error is consistent with a text difference rather than a timeout or a crash. Because of this, the mechanisms used in the TestController are unavailable to this class, hence the hard-coding of the process name. It is possible to entirely define TestController::webProcessName() in the TestController header, which allows the InjectedBundle library to access this function, but such a change seemed to violate the intent and future plans for the function.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>