<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - WTR needs an implementation of setAutomaticLinkDetectionEnabled"
href="https://bugs.webkit.org/show_bug.cgi?id=87162">bug 87162</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #285752 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - WTR needs an implementation of setAutomaticLinkDetectionEnabled"
href="https://bugs.webkit.org/show_bug.cgi?id=87162#c8">Comment # 8</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - WTR needs an implementation of setAutomaticLinkDetectionEnabled"
href="https://bugs.webkit.org/show_bug.cgi?id=87162">bug 87162</a>
from <span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=285752&action=diff" name="attach_285752" title="Patch">attachment 285752</a> <a href="attachment.cgi?id=285752&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=285752&action=review">https://bugs.webkit.org/attachment.cgi?id=285752&action=review</a>
<span class="quote">> Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp:310
> + if (static_cast<bool>(enabled) == TextChecker::state().isAutomaticLinkDetectionEnabled)</span >
static_cast<bool>(enabled) is wrong here; just "enabled" will do
<span class="quote">> Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp:315
> + fputs("Automatic link detection undefined for this platform\n", stderr);</span >
It’s not appropriate to write directly to stderr from this class.
<span class="quote">> Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:52
> + WK_EXPORT void WKBundleSetAutomaticLinkDetectionEnabled(WKBundleRef bundleRef, WKBundlePageGroupRef pageGroupRef, bool enabled);</span >
This should not be indented. Please match the lines above and below this.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>