<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Move functionality common to Darwin ports into a base class"
href="https://bugs.webkit.org/show_bug.cgi?id=160709#c9">Comment # 9</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Move functionality common to Darwin ports into a base class"
href="https://bugs.webkit.org/show_bug.cgi?id=160709">bug 160709</a>
from <span class="vcard"><a class="email" href="mailto:dbates@webkit.org" title="Daniel Bates <dbates@webkit.org>"> <span class="fn">Daniel Bates</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=160709#c5">comment #5</a>)
<span class="quote">> (In reply to <a href="show_bug.cgi?id=160709#c4">comment #4</a>)
> > Comment on <span class="bz_obsolete"><a href="attachment.cgi?id=285675&action=diff" name="attach_285675" title="Patch">attachment 285675</a> <a href="attachment.cgi?id=285675&action=edit" title="Patch">[details]</a></span>
> > Patch
> >
> > View in context:
> > <a href="https://bugs.webkit.org/attachment.cgi?id=285675&action=review">https://bugs.webkit.org/attachment.cgi?id=285675&action=review</a>
> ....
> >
> > > Tools/Scripts/webkitpy/port/darwin.py:199
> > > + def xcrun_find(self, command, fallback):
> > > + _log.warn("xcrun undefined; falling back to '%s'." % fallback)
> > > + return fallback
> >
> > This does not seem correct. We can and should make use of xcrun to find
> > command line tools for both the Mac and iOS ports.
>
> We do use xcrun for both Mac and iOS, but iOS assumes it's being run through
> a simulator, so it has a few extra arguments. ios.py line 400 has the iOS
> simulator xcrun.</span >
Can we share more of the common code from MacPort.xcrun_find() and IOSPort.xcrun_find()?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>