<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:achristensen@apple.com" title="Alex Christensen <achristensen@apple.com>"> <span class="fn">Alex Christensen</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Resource Timing: Make PerformanceEntryList a sequence as per spec"
href="https://bugs.webkit.org/show_bug.cgi?id=160963">bug 160963</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #286385 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Resource Timing: Make PerformanceEntryList a sequence as per spec"
href="https://bugs.webkit.org/show_bug.cgi?id=160963#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Resource Timing: Make PerformanceEntryList a sequence as per spec"
href="https://bugs.webkit.org/show_bug.cgi?id=160963">bug 160963</a>
from <span class="vcard"><a class="email" href="mailto:achristensen@apple.com" title="Alex Christensen <achristensen@apple.com>"> <span class="fn">Alex Christensen</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=286385&action=diff" name="attach_286385" title="Patch">attachment 286385</a> <a href="attachment.cgi?id=286385&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=286385&action=review">https://bugs.webkit.org/attachment.cgi?id=286385&action=review</a>
<span class="quote">> Source/WebCore/page/Performance.cpp:92
> -RefPtr<PerformanceEntryList> Performance::getEntries() const
> +Vector<RefPtr<PerformanceEntry>> Performance::getEntries() const</span >
Could these be Ref<PerformanceEntry>s?
<span class="quote">> Source/WebCore/page/Performance.cpp:105
> + std::sort(entries.begin(), entries.end(), PerformanceEntry::startTimeCompareLessThan);</span >
do we have to sort everything?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>