<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:ossy@webkit.org" title="Csaba Osztrogonác OOO_until_5th_Sep <ossy@webkit.org>"> <span class="fn">Csaba Osztrogonác OOO_until_5th_Sep</span></a>
</span> changed
<a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Remove StyleCachedImageSet"
href="https://bugs.webkit.org/show_bug.cgi?id=160941">bug 160941</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>achristensen@apple.com, ossy@webkit.org
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Remove StyleCachedImageSet"
href="https://bugs.webkit.org/show_bug.cgi?id=160941#c10">Comment # 10</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Remove StyleCachedImageSet"
href="https://bugs.webkit.org/show_bug.cgi?id=160941">bug 160941</a>
from <span class="vcard"><a class="email" href="mailto:ossy@webkit.org" title="Csaba Osztrogonác OOO_until_5th_Sep <ossy@webkit.org>"> <span class="fn">Csaba Osztrogonác OOO_until_5th_Sep</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=160941#c9">comment #9</a>)
<span class="quote">> <a href="https://trac.webkit.org/r204560">https://trac.webkit.org/r204560</a></span >
It broke the Apple Mac cmake build:
/Volumes/Data/slave/elcapitan-cmake-debug/build/Source/WebCore/rendering/style/StyleCachedImage.cpp:50:16: error: no viable conversion from 'WebCore::CSSImageSetValue *' to 'PassRefPtr<WebCore::CSSValue>'
return const_cast<CSSImageSetValue*>(m_cssImageSetValue);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Volumes/Data/slave/elcapitan-cmake-debug/build/Source/WTF/wtf/PassRefPtr.h:49:9: note: candidate constructor not viable: cannot convert argument of incomplete type 'WebCore::CSSImageSetValue *' to 'WebCore::CSSValue *'
PassRefPtr(T* ptr) : m_ptr(ptr) { refIfNotNull(ptr); }
^
/Volumes/Data/slave/elcapitan-cmake-debug/build/Source/WTF/wtf/PassRefPtr.h:53:9: note: candidate constructor not viable: cannot convert argument of incomplete type 'WebCore::CSSImageSetValue *' to 'const WTF::PassRefPtr<WebCore::CSSValue> &'
PassRefPtr(const PassRefPtr& o) : m_ptr(o.leakRef()) { }
^
/Volumes/Data/slave/elcapitan-cmake-debug/build/Source/WTF/wtf/PassRefPtr.h:54:30: note: candidate template ignored: could not match 'PassRefPtr<type-parameter-0-0>' against 'WebCore::CSSImageSetValue *'
template<typename U> PassRefPtr(const PassRefPtr<U>& o) : m_ptr(o.leakRef()) { }
^
/Volumes/Data/slave/elcapitan-cmake-debug/build/Source/WTF/wtf/PassRefPtr.h:58:30: note: candidate template ignored: could not match 'RefPtr<type-parameter-0-0>' against 'WebCore::CSSImageSetValue *'
template<typename U> PassRefPtr(const RefPtr<U>&);
^
/Volumes/Data/slave/elcapitan-cmake-debug/build/Source/WTF/wtf/PassRefPtr.h:59:30: note: candidate template ignored: could not match 'Ref<type-parameter-0-0>' against 'WebCore::CSSImageSetValue *'
template<typename U> PassRefPtr(Ref<U>&& reference) : m_ptr(&reference.leakRef()) { }
^
/Volumes/Data/slave/elcapitan-cmake-debug/build/Source/WTF/wtf/PassRefPtr.h:60:30: note: candidate template ignored: could not match 'RefPtr<type-parameter-0-0>' against 'WebCore::CSSImageSetValue *'
template<typename U> PassRefPtr(RefPtr<U>&& reference) : m_ptr(reference.leakRef()) { }</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>