<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Move the redirected XComposite window to the web process"
href="https://bugs.webkit.org/show_bug.cgi?id=160389#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Move the redirected XComposite window to the web process"
href="https://bugs.webkit.org/show_bug.cgi?id=160389">bug 160389</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=160389#c2">comment #2</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=284964&action=diff" name="attach_284964" title="Patch">attachment 284964</a> <a href="attachment.cgi?id=284964&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=284964&action=review">https://bugs.webkit.org/attachment.cgi?id=284964&action=review</a>
>
> So it makes AC mode not suck? :)</span >
Yes.
<span class="quote">> This one really should be looked at by a graphics reviewer; if it gets stuck
> awaiting review, you can ping me after a few days.</span >
Thanks!
<span class="quote">> > Source/WebCore/platform/graphics/x11/PlatformDisplayX11.cpp:66
> > +bool PlatformDisplayX11::supportsXComposite()
>
> Can you make it const, as it should be, if you make m_supportsXComposite
> mutable? Or does the call to XCompositeQueryExtension prevent that?</span >
I'll try.
<span class="quote">> > Source/WebCore/platform/graphics/x11/PlatformDisplayX11.cpp:75
> > +bool PlatformDisplayX11::supportsXDamage(int& damageEventBase)
>
> Can you make it const, as it should be, if you make m_damageEventBase
> mutable? Or does the call to XDamageQueryExtension prevent that?
>
> > Source/WebCore/platform/graphics/x11/PlatformDisplayX11.cpp:79
> > + m_supportsXDamage = XDamageQueryExtension(m_display, &eventBase, &errorBase);
>
> EFL build is failing here:</span >
I'll fix the build.
<span class="quote">> lib/libwebcore_efl.a(lib/../Source/WebCore/CMakeFiles/WebCore.dir/platform/
> graphics/x11/PlatformDisplayX11.cpp.o):PlatformDisplayX11.cpp:function
> WebCore::PlatformDisplayX11::supportsXDamage(int&): error: undefined
> reference to 'XDamageQueryExtension'
> collect2: error: ld returned 1 exit status
>
> We link with ${X11_Xdamage_LIB} in WebCore/PlatformGtk.cmake, but EFL does
> not; you'll need to add it to WebCore_LIBRARIES.
>
> > Source/WebKit2/UIProcess/gtk/XDamageNotifier.cpp:75
> > +GdkFilterReturn XDamageNotifier::filterXDamageEvent(GdkXEvent* event, GdkEvent*, XDamageNotifier* notifier)
>
> Since it doesn't access any member variables, I would move it outside the
> class.</span >
Then I would need to make notify public which is not.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>