<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: Media controls accessibility improvement"
href="https://bugs.webkit.org/show_bug.cgi?id=160223#c16">Comment # 16</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: Media controls accessibility improvement"
href="https://bugs.webkit.org/show_bug.cgi?id=160223">bug 160223</a>
from <span class="vcard"><a class="email" href="mailto:eric.carlson@apple.com" title="Eric Carlson <eric.carlson@apple.com>"> <span class="fn">Eric Carlson</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=284671&action=diff" name="attach_284671" title="patch">attachment 284671</a> <a href="attachment.cgi?id=284671&action=edit" title="patch">[details]</a></span>
patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=284671&action=review">https://bugs.webkit.org/attachment.cgi?id=284671&action=review</a>
<span class="quote">>>> Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:424
>>> + timeline.step = 1;
>>
>> While 1 will be a better value than .01 for some movies, it will be much worse for very short files, and it still won't be great for long files. Can you set it to a percentage of the duration in updateDuration instead? You may want to vary the percentage based on duration, e.g. 1% of a 90 second file is almost a second but 1% of a 90 minute is almost a minute, but a I'll bet you can come up with reasonable values with some experimentation.
>
> We have come up with some cases that, let me know your thought:
> 1. If video is less then 10sec we do 0.5 second step
> 2. If video is between 10sec to 1min we do 1 second step
> 3. If video is between 1min to 10min we do 10 second step
> 4. If video is between 10min to 60min we do 30 second step
> 5. If video is more than 60min we do 60 second step.</span >
Now that I have played around with this, I don't think .step is the right way to fix this, is it possible to fix this problem with something else? While .step makes the slider more usable from the keyboard, it also makes it almost unusable as a media timeline slider because it is not possible to seek to specific times: e.g. in an hour long video it is only possible to seek to every minute.
Play around with this fiddle to see what I mean: <a href="https://jsfiddle.net/jvL5nnnd">https://jsfiddle.net/jvL5nnnd</a></pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>