<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW - [soup] Incorrect usage of relaxAdoptionRequirement in the constructor of SocketStreamHandle"
href="https://bugs.webkit.org/show_bug.cgi?id=160281">160281</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>[soup] Incorrect usage of relaxAdoptionRequirement in the constructor of SocketStreamHandle
</td>
</tr>
<tr>
<th>Classification</th>
<td>Unclassified
</td>
</tr>
<tr>
<th>Product</th>
<td>WebKit
</td>
</tr>
<tr>
<th>Version</th>
<td>WebKit Nightly Build
</td>
</tr>
<tr>
<th>Hardware</th>
<td>Unspecified
</td>
</tr>
<tr>
<th>OS</th>
<td>Unspecified
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Severity</th>
<td>Normal
</td>
</tr>
<tr>
<th>Priority</th>
<td>P2
</td>
</tr>
<tr>
<th>Component</th>
<td>Platform
</td>
</tr>
<tr>
<th>Assignee</th>
<td>webkit-unassigned@lists.webkit.org
</td>
</tr>
<tr>
<th>Reporter</th>
<td>Hironori.Fujii@sony.com
</td>
</tr></table>
<p>
<div>
<pre>(<a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [GTK] ASSERTION FAILED: !m_adoptionIsRequired when Inspector Server is connected"
href="show_bug.cgi?id=160229#c6">Bug 160229 Comment #6</a>)
<span class="quote">> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=284672&action=review">https://bugs.webkit.org/attachment.cgi?id=284672&action=review</a>
>
> > Source/WebCore/ChangeLog:11
> > + An assertion fails because refcount of SocketStreamHandle is
> > + incremented before adoptRef, in the constructor of
> > + SocketStreamHandle. The constructor of SocketStreamHandle needs
> > + to increment recount because it passes this pointer to libsoup.
>
> This is an incorrect solution; relaxAdoptionRequirement should *not* be used
> here. The correct solution is to make the constructor private and make a
> public creation function which does the rest of the job of initializing the
> object, *after* the constructor has run and we have the object pointer
> inside a Ref already.</span ></pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>