<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span> changed
<a class="bz_bug_link
bz_status_UNCONFIRMED "
title="UNCONFIRMED - [WK2] Keyboard menu key should show context menu"
href="https://bugs.webkit.org/show_bug.cgi?id=72099">bug 72099</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #284771 Flags</td>
<td>commit-queue?
</td>
<td>commit-queue-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_UNCONFIRMED "
title="UNCONFIRMED - [WK2] Keyboard menu key should show context menu"
href="https://bugs.webkit.org/show_bug.cgi?id=72099#c24">Comment # 24</a>
on <a class="bz_bug_link
bz_status_UNCONFIRMED "
title="UNCONFIRMED - [WK2] Keyboard menu key should show context menu"
href="https://bugs.webkit.org/show_bug.cgi?id=72099">bug 72099</a>
from <span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=284771&action=diff" name="attach_284771" title="Proposed patch">attachment 284771</a> <a href="attachment.cgi?id=284771&action=edit" title="Proposed patch">[details]</a></span>
Proposed patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=284771&action=review">https://bugs.webkit.org/attachment.cgi?id=284771&action=review</a>
Ah great, I noticed this was broken, it's nice to have a patch.
<span class="quote">> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:827
> + if ((event->keyval == GDK_KEY_Menu) || (((event)->state & GDK_SHIFT_MASK) && GDK_KEY_F10))</span >
Remove the extra parens around event here.
<span class="quote">> Source/WebKit2/UIProcess/WebPageProxy.cpp:4567
> +void WebPageProxy::handleContextMenuKeyEvent()</span >
Carlos, owners, do you think we should use PLATFORM(GTK) guards here, since it's only used by GTK? It's not really platform specific, but only used by a single platform, so I'm not sure.
<span class="quote">> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2157
> + Frame& frame = m_page->focusController().focusedOrMainFrame();</span >
You have to adjust the #ifdefs here to avoid the unused variable build failure on Mac. You should guard the entire implementation of the function with #if !PLATFORM(MAC).
<span class="quote">> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2160
> +#if !PLATFORM(MAC)</span >
But TBH I'm not sure if it's the right #if, we have iOS nowadays after all. Maybe !PLATFORM(COCOA)? Or maybe put the whole function in a PLATFORM(GTK) guard? Let's see what Carlos and Apple say to use here.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>